0

My code:

for x in remove_zeros:
    if x == remove_zeros[-1]:
        x = '0' + x
    else:
        x = '1' + x

For some reason this does not do anything to the variables. I've looked up how to fix this, and nothing works at all. Basically, I'm detecting if an element in a list is the last element or not, and then if it is, I'm either adding a 0 or a 1 in front of it. I cannot figure out how to make this work.

Marco D.G.
  • 2,317
  • 17
  • 31
VzxZrV6fDT
  • 1
  • 1
  • 1
  • On each iteration of the loop `x` points to the next item in the sequence `remove_zeros`. Assigning a new value to `x` will not change `remove_zeros`. [For loops](https://docs.python.org/dev/tutorial/controlflow.html#for-statements). [Assignment statements](https://docs.python.org/dev/reference/simple_stmts.html#assignment-statements) – wwii Apr 12 '20 at 15:02

6 Answers6

4

When you write x = '0' + x, you simply overwrite the value to which the name x points to. You do not directly modify the value inside the list that x was originally pointing to with each new execution of the for x in remove_zeros: loop.

You can modify the value inside the list by accessing it directly with its index and assigning a new value to it. An easy way to do this is with enumerate, which loops over the list indices and values at the same time:

 for index, x in enumerate(remove_zeros):
            if x == remove_zeros[-1]:
                remove_zeros[index] = '0' + x
            else:
                remove_zeros[index] = '1' + x
jfaccioni
  • 7,099
  • 1
  • 9
  • 25
1

In a for loop, the control variable (x) is a temporary variable that is reassigned at every iteration. In the case of strings, it is not a reference to the element of your list but a separate copy. This means that changing x inside the loop will have no effect on the list.

Given that you are modifying every element in the list, you can do this without resorting to indexes (which is not very Pythonic). Try producing a new list using a list comprehension:

remove_zeros = [ '10'[x==remove_zeros[-1]]+x for x in remove_zeros ]
Alain T.
  • 40,517
  • 4
  • 31
  • 51
0

Use index numbers instead of a temporary variable x to modify the value of a list:

for i in range(len(remove_zeros)):
  remove_zeros[i] = ('0' if remove_zeros[i] == remove_zeros[-1] else '1') + remove_zeros[i]
SteveK
  • 995
  • 5
  • 17
0

You are changing x transiently during each iteration of the loop, but these changes are not being saved anywhere. Every time the loop repeats x is redefined to be the next element in the list and the modification you have made is lost.

Instead, overwrite the existing list elements with your desired values. One way to do this is using enumerate:

 for n,x in enumerate(remove_zeros):
    if x == remove_zeros[-1]:
        remove_zeros[n] = '0'+x
    else:
        remove_zeros[n] = '1'+x
corvus
  • 556
  • 7
  • 18
0

for loop control variable is not a reference to an element of the list, it is a copy of an element. Changing it won't change the element of the list. You can either store your results in another list:

result = []
for x in remove_zeros:
    if x == remove_zeros[-1]:
        result.append('0' + x)
    else:
        result.append('1' + x)

or do what @jfaccioni suggested. BTW, either way you're not checking if x is the last element of the list, but whether x is equal to the last element. Consider a list: ['3','0','1','2','3'] … you'll prepend 0 to both 3s in the list.

Błotosmętek
  • 12,717
  • 19
  • 29
0

It is because you're working on your loop variable x and not on the actual element you want to change. The element in remove_zeros stays untouched. Change your code to something like:

for i in range(len(remove_zeros)):
    remove_zeros[i] = '0' + remove_zeros[i] if remove_zeros[i] == remove_zeros[-1] else '1' + remove_zeros[i]
LetItBeAndre
  • 151
  • 1
  • 10