PHP why isnt my register and login scripts working?

Question

My php script for registry is not working, its returning

Warning: mysql_query() [function.mysql-query]: Access denied for user '**'@'localhost' (using password: NO) in /home/**/public_html/register.php on line 10

and

Warning: mysql_query() [function.mysql-query]: A link to the server could not be established in /home/**/public_html/register.php on line 10

Register.php

    <?php
    require('connect.php');
    // If the values are posted, insert them into the database.
    if (isset($_POST['username']) && isset($_POST['password'])){
        $username = $_POST['username'];
        $email = $_POST['email'];
        $password = $_POST['password'];

        $query = "INSERT INTO user (username, password, email) VALUES ('$username', '$password', '$email')";
        $result = mysql_query(!$query);
        if(!$result){
            $msg = "User Created Successfully.";
        }
    }
    ?>
<!DOCTYPE html>
<html>
<head>
<title>InfamousBurns - Register</title>
<link rel="stylesheet" type="text/css" href="style.css" />
</head>
<body>
    <!-- Form for logging in the users -->
<div>
<?php
    if(isset($msg) & !empty($msg)){
        echo $msg;
    }
 ?>
<h1 id="post">Register</h1>
<form action="" method="POST">
    <p id="post"><label>User Name : </label>
    <input id="username" type="text" name="username" placeholder="username" />
    </p>

    <p id="post"><label>E-Mail&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; : </label>
     <input id="password" type="email" name="email" required placeholder="vivek@email.com" />           </p>

     <p id="post"><label>Password&nbsp;&nbsp; : </label>
     <input id="password" type="password" name="password" placeholder="password" /></p>

    <a id="button" href="login.php">Login</a>
    <input  id="post" type="submit" name="submit" value="Register" />
    </form>

</div>
</body>
</html>

"Warning: mysql_query() [function.mysql-query]: Access denied for user '**'@'localhost' (using password: NO) in /home/**/public_html/register.php on line 10" - literally told you what's wrong, right there. Your aren't entering the correct username/password when attempting to connect. — lxndr, Feb 25 '14 at 19:20
Google the error. If you can't Google errors then you can't program. If you actually try to understand what your research says and you can't understand it then ask, don't ask us what's wrong when the error is just piercing your eyes. It's right there. — Jonast92, Feb 25 '14 at 19:21
Regardless of that, you're exposed to SQL Injection. See [Why shouldn't I use mysql\_\* functions in PHP?](http://stackoverflow.com/q/12859942). — Madara's Ghost, Feb 25 '14 at 19:21
$result = mysql_query(!$query); Why do you have `(!$query)`? — Paul McLoughlin, Feb 25 '14 at 19:22
@InfamousBurns - no, you're not. The code doesn't make mistakes, the developer makes them. It says you entered incorrect information. — lxndr, Feb 25 '14 at 19:24
`$result = mysql_query(!$query);` the exclamation mark is too much too. — Ulrich Thomas Gabor, Feb 25 '14 at 19:25
@GhostGambler It's using `require`. If that fails, the script produces a fatal E_COMPILE_ERROR level error. See http://php.net/require — Mike, Feb 25 '14 at 19:26
Nevertheless it tries to establish the connection first with the `mysql_query` call. Then the `connect.php` is empty or whatever. — Ulrich Thomas Gabor, Feb 25 '14 at 19:28
SERIOUSLY? You are CLOSING the connection at the end of the file. — Ulrich Thomas Gabor, Feb 25 '14 at 19:29
@InfamousBurns you're far better to add the code to your question instead of an image. Just X out your credentials. — Mike, Feb 25 '14 at 19:29
Sorry, but this was really... like ... you know what I mean ;) — Ulrich Thomas Gabor, Feb 25 '14 at 19:32
@InfamousBurns stop using `mysql_*` functions. They are deprecated. Instead use PDO or mysqli. Do it right from the beginning. — Mike, Feb 25 '14 at 19:32
@InfamousBurns you should listen then... As it is now, if your script ever did actually manage to connect to the server, you are wide open to SQL injection attacks. — Mike, Feb 25 '14 at 19:34
AND definitely look into http://php.net/password_hash. If you don't have PHP 5.5 look in the comments for the compatibility functions. **DO NOT STORE PASSWORDS IN PLAIN TEXT. EVER.** — Mike, Feb 25 '14 at 19:36

user3263978 · Answer 1 · 2014-02-25T19:48:44.497

0

This happening because in "connect.php" your details to the MySQL database are not correct, because you haven't posted the actual connect.php details I can only assume that you've misspelt something.

EDIT 1:

Where you have

$selected = mysql_select_db($dbhandle);

change it to

$selected = mysql_select_db($mysql_database);

EDIT 2

Can I also suggest using PDO instead... example below for db connection below

<?php
    $host = "host";
    $user = "username";
    $pass = "pass";
    $db = "database name";

    try {
        $link = new PDO("mysql:host=$host;dbname=$db",$user,$pass);
    } catch (PDOException $e) {
        die();
    }

Of course this means having to change your SQL queries around a little bit and use prepared statements instead, I'm sure you can find some help for it online though

edited Feb 25 '14 at 19:48

answered Feb 25 '14 at 19:25

user3263978

193
1
2
14

I would assume from `using password: NO` that the password is not getting passed to `mysql_connect`. – Mike Feb 25 '14 at 19:27
I wouldn't echo `$e->getMessage()` to the browser. With a failed connection it will echo your connection credentials in plain text. – Mike Feb 25 '14 at 19:37
@Mike good point... it is merely for testing purposes to check the credentials upon fail. Will take that part out – user3263978 Feb 25 '14 at 19:43

score 0 · Answer 2 · answered Feb 25 '14 at 19:39

If the login information is correct check the location of the file. It looks like connect.php should be in the public_html directory based on the way you are including it in Register.php. If its in a subdirectory or something make sure you are using the correct path in the require() function. And make sure any capital letters are capitalized as normal when using file locations.

PHP why isnt my register and login scripts working?

2 Answers2